Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ensure Constraint of Solar and Solar-hsat with Post Discretization #1342

Merged
merged 1 commit into from
Oct 2, 2024

Conversation

toniseibold
Copy link
Contributor

@toniseibold toniseibold commented Oct 2, 2024

Bugfix

Changes proposed in this Pull Request

When the post discretization is enabled, the function add_solar_potential_constraints is called multiple times.
The first time, the optimal capacity of generators with carrier solar-hsat is zero. However, the second time, the optimal capacity can be greater than zero which would then overly reduce the potential.
Since the p_nom is set in the next planning horizon in the rule add_brownfield switching from p_nom_opt to p_nom is the correct way to formulate the boundary condition.

Checklist

  • I tested my contribution locally and it works as intended.
  • Code and workflow changes are sufficiently documented.
    not applicable
  • Changed dependencies are added to envs/environment.yaml.
    not applicable
  • Changes in configuration options are added in config/config.default.yaml.
    not applicable
  • Changes in configuration options are documented in doc/configtables/*.csv.
    not applicable
  • Sources of newly added data are documented in doc/data_sources.rst.
    not applicable
  • A release note doc/release_notes.rst is added.
    not applicable

@toniseibold toniseibold requested a review from lindnemi October 2, 2024 13:56
@toniseibold toniseibold marked this pull request as ready for review October 2, 2024 13:56
@lindnemi lindnemi merged commit b6c024c into ariadne2 Oct 2, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants