Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enhance configuration flexibility #86

Merged
merged 3 commits into from
Nov 17, 2022
Merged

Enhance configuration flexibility #86

merged 3 commits into from
Nov 17, 2022

Conversation

davide-f
Copy link
Collaborator

@davide-f davide-f commented Nov 16, 2022

Closes # (if applicable).

Change proposed in this Pull Request

This PR aims at providing a flexible interface to accommodate custom configuration files.
In particular:

  • the docstring of config is added to collect function
  • the new extend_config option is added to collect function, whose goal is to update the default config file

Unsure if this is a wanted feature.
I'm thinking that as a workaround, someone may update the config externally, though this is easier for the user.
Currenly, we have this feature in the fork for pypsa-earth.

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Other

Checklist

  • I have added a note to release notes doc/release_notes.rst.
  • I have used pre-commit run --all to lint/format/check my contribution
  • I have documented the effects of my code changes in the documentation doc/.
  • I have adjusted the docstrings in the code appropriately.

@FabianHofmann
Copy link
Contributor

Makes sense :) Can we name the argument config_update?

@davide-f
Copy link
Collaborator Author

@FabianHofmann Done, thanks :)
Sorry for the 3 PRs opened at the same time; they are old changes and I guesssed you preferred to have the features splitted to ease the review.

@FabianHofmann
Copy link
Contributor

No worry, that's good! Makes life easier :)

@FabianHofmann FabianHofmann merged commit 19d0586 into PyPSA:master Nov 17, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants