Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Status filter to GCPT and improve performances #154

Merged
merged 3 commits into from
Apr 4, 2024

Conversation

davide-f
Copy link
Collaborator

@davide-f davide-f commented Mar 10, 2024

Closes #153

Change proposed in this Pull Request

  • Adds a filtering on the status column for GCPT database, similarly to the other GEM databases
  • Restore a missing technology-specification for the GWPT database
  • Revise the ordering of selected replacing in GEM databases to improve perfomances: the assign/replace are performed after the filtering

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Other

Checklist

  • I have added a note to release notes doc/release_notes.rst.
  • I have used pre-commit run --all to lint/format/check my contribution
  • I have documented the effects of my code changes in the documentation doc/.
  • I have adjusted the docstrings in the code appropriately.

@davide-f
Copy link
Collaborator Author

@stuenergy FYI

@davide-f
Copy link
Collaborator Author

davide-f commented Apr 4, 2024

Hello :)
Are there updates here? @FabianHofmann not sure who I should talk to now

@FabianHofmann
Copy link
Contributor

Hey @davide-f looks all good, you can merge. Thanks for pinging me, it wasn't on my radar

@davide-f
Copy link
Collaborator Author

davide-f commented Apr 4, 2024

Fantastic! many thanks. It may be good to push a minor release too, what do you think?

@davide-f davide-f merged commit c331a3a into PyPSA:master Apr 4, 2024
2 checks passed
@FabianHofmann
Copy link
Contributor

yeah sure :) should I do it?

@davide-f
Copy link
Collaborator Author

davide-f commented Apr 4, 2024

yeah sure :) should I do it?

If you can do it easily feel free to do it, or let's coordinate ;)

@davide-f
Copy link
Collaborator Author

davide-f commented Apr 7, 2024

Done :) I guessed you were busy

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Missing Status check on GCPT
2 participants