Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update GEM solar and wind datasets to May-2023. #121

Merged
merged 3 commits into from
Jun 29, 2023

Conversation

Tomkourou
Copy link
Contributor

@Tomkourou Tomkourou commented May 31, 2023

Closes # (if applicable).

Change proposed in this Pull Request

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Other

Checklist

  • I have added a note to release notes doc/release_notes.rst.
  • I have used pre-commit run --all to lint/format/check my contribution
  • I have documented the effects of my code changes in the documentation doc/.
  • I have adjusted the docstrings in the code appropriately.

@Tomkourou Tomkourou marked this pull request as ready for review May 31, 2023 16:23
@davide-f
Copy link
Collaborator

Hello!
Nice update! I think comment by @FabianHofmann may be welcome.
Personally, I think we should avoid the manual update from Jan to May, etc.
I understand that the pointed resource is stored in @pz-max github. I think it would be best to always name in github a file "..._latest" so that there is no need to open a PR every month.

What do you think? @FabianHofmann @Tomkourou @pz-max

@pz-max
Copy link
Contributor

pz-max commented Jun 23, 2023

Agree with @davide-f. Great suggestion! This allows us to be more flexible.
I am creating a copy and call it latest in my data repo.

Update: DONE https://github.com/pz-max/gem-powerplant-data

TODO: now we only need to change the links in powerplantmatching

Ideally, we talk with GEM that they also have something like latest & we get the link from them

@Tomkourou
Copy link
Contributor Author

Agree that's probably wise :)

@FabianHofmann
Copy link
Contributor

Very good idea!

@FabianHofmann
Copy link
Contributor

Let's merge this for now and set up the "latest" reference later

@FabianHofmann FabianHofmann merged commit dd7099e into PyPSA:master Jun 29, 2023
@pz-max pz-max mentioned this pull request Jun 29, 2023
6 tasks
@Tomkourou Tomkourou deleted the update-gem-wind-solar-05-2023 branch June 29, 2023 08:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants