New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

build: don't pass --target if not needed #258

Merged

davidhewitt merged 1 commit into PyO3:main from davidhewitt:default-target

Jul 1, 2022

Member

davidhewitt commented Jul 1, 2022

Closes #229

Added a check whether the inferred target is the rust host, and if so, skip passing --target.

I did a little bit of refactoring at the same time;

merged private and utils into a _utils module, shuffled a couple of functions around
moved functions which query rustc for metadata into a new setuptools_rust.rustc_info module and added @cache decorator to all of these (as we expect rustc to give stable output)

davidhewitt force-pushed the default-target branch 2 times, most recently from 52e8229 to dccb720 Compare

July 1, 2022 17:56


          build: don't pass --target if not needed

a09c530

davidhewitt force-pushed the default-target branch from dccb720 to a09c530 Compare

July 1, 2022 18:36

davidhewitt merged commit 3f97179 into PyO3:main

davidhewitt deleted the default-target branch

July 1, 2022 19:19

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet