Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Build and test namespace_package wheel for emscripten-wasm32 #240

Closed
wants to merge 10 commits into from

Conversation

hoodmane
Copy link
Contributor

I will create separate PRs splitting off the changes to the actual package code.

It seems that the prebuilt emscripten-wasm toolchain doesn't come with relocations. I need to use -Zbuild-std to prevent a bunch of errors like

relocation R_WASM_MEMORY_ADDR_LEB cannot be used against symbol `__THREW__`; recompile with -fPIC

What I do not understand is why I am not needing -Zbuild-std to get cryptography to build in
pyodide/pyodide#2683
It's quite mysterious.

@hoodmane
Copy link
Contributor Author

If we get Pyodide out of tree builds working, we could simplify this a lot and build and test all four test packages using pytest inside of Pyodide.

@davidhewitt
Copy link
Member

davidhewitt commented Jun 12, 2022

It seems that the prebuilt emscripten-wasm toolchain doesn't come with relocations.

Searching for that error some more, I came across rust-lang/rust#60231 (comment). I wonder if that works?

@hoodmane
Copy link
Contributor Author

I'm going to redo this using Pyodide instead of compiling a separate interpreter. I think this will work better.

@davidhewitt davidhewitt mentioned this pull request Jun 28, 2022
@messense messense closed this Aug 7, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants