Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove the dependency on tomli to simplify installation #200

Merged
merged 1 commit into from
Dec 4, 2021

Conversation

alex
Copy link
Contributor

@alex alex commented Dec 4, 2021

Depending on tomli produces circular dependencies when attempting to install from sdists only: pyca/cryptography#6671

Depending on tomli produces circular dependencies when attempting to install from sdists only: pyca/cryptography#6671
@davidhewitt
Copy link
Member

Thanks, using cargo metadata is a brilliant solution. Reading the cryptography thread, sorry for the pain caused.

I'll follow up this PR tomorrow morning with a quick refactoring so we only need to call cargo metadata once (we use it in one other place too) and then put this patch release live.

@davidhewitt davidhewitt merged commit a9cd47c into PyO3:main Dec 4, 2021
@alex
Copy link
Contributor Author

alex commented Dec 5, 2021

Sounds great, thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants