Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix RustExtension.install_script #154

Merged
merged 4 commits into from
Jul 21, 2021
Merged

Fix RustExtension.install_script #154

merged 4 commits into from
Jul 21, 2021

Conversation

messense
Copy link
Member

Fixes #153

@messense messense mentioned this pull request Jul 21, 2021
Closed
davidhewitt
davidhewitt approved these changes Jul 21, 2021
View reviewed changes
Copy link
Member

@davidhewitt davidhewitt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Perfect, thank you for fixing so quickly! I think worth having a CHANGELOG entry?

@messense messense merged commit b56d126 into PyO3:main Jul 21, 2021
@messense messense deleted the fix-script branch July 21, 2021 07:51
@messense messense mentioned this pull request Nov 3, 2021
Closed
@davidhewitt davidhewitt mentioned this pull request Nov 21, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@davidhewitt davidhewitt davidhewitt approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Error with Binding.Exec and script=True
2 participants
@messense @davidhewitt