Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

drop support for PyPy 3.7 and 3.8 #470

Merged
merged 1 commit into from
Nov 20, 2024
Merged

drop support for PyPy 3.7 and 3.8 #470

merged 1 commit into from
Nov 20, 2024

Conversation

Icxolu
Copy link
Contributor

@Icxolu Icxolu commented Nov 20, 2024

Upstream PyO3 does not support PyPy 3.7 and 3.8 anymore since 0.23 (PyO3/pyo3#4582). Testing against PyPy 3.9 and 3.10 now. Also there are numpy wheels for PyPy on Windows-x64 and MacOS now, so I included it in CI.

Upstream PyO3 does not support PyPy 3.7 and 3.8 anymore since 0.23. Testing against PyPy 3.9 and 3.10 now.
Copy link
Member

@davidhewitt davidhewitt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, thanks 👍

@@ -1,5 +1,6 @@
# Changelog

- v0.23.0
- Drop support for PyPy 3.7 and 3.8. ([#470](https://github.com/PyO3/rust-numpy/pull/470))
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We probably should have added an entry for Element: Sync, maybe just fixup here (or as a follow-up)?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Agreed 👍, will include it in #457, haven't written the entry for that one yet.

@Icxolu Icxolu merged commit 9eaa51f into PyO3:main Nov 20, 2024
68 checks passed
@Icxolu Icxolu deleted the ci-pypy branch November 20, 2024 22:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants