Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow omitting return type for #[pyproto] #998

Merged
merged 1 commit into from
Jun 23, 2020
Merged

Allow omitting return type for #[pyproto] #998

merged 1 commit into from
Jun 23, 2020

Conversation

davidhewitt
Copy link
Member

This builds on #996 by removing the need to write -> () in the return type for #[pyproto] methods.

@davidhewitt davidhewitt force-pushed the pyproto-optional-return-ty branch from 9517284 to a9c7e12 Compare June 23, 2020 10:51
@kngwyu
Copy link
Member

kngwyu commented Jun 23, 2020

LGTM, thank you!

@kngwyu kngwyu merged commit a5e3d4e into PyO3:master Jun 23, 2020
@davidhewitt davidhewitt deleted the pyproto-optional-return-ty branch December 24, 2021 02:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kngwyu kngwyu kngwyu approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@davidhewitt @kngwyu