subclass support #64
Merged
subclass support #64
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
messense
commented
Jul 27, 2017
pyo3cls/src/py_class.rs
Outdated
| @@ -440,6 +440,10 @@ fn parse_attribute(attr: String) -> (HashMap<&'static str, syn::Ident>, | |||
| flags.push(syn::Ident::from("_pyo3::typeob::PY_TYPE_FLAG_WEAKREF")); | |||
| continue | |||
| } | |||
| "basetype" => { | |||
There was a problem hiding this comment.
I am not sure this is a good name. Feels odd.
fafhrd91
reviewed
Jul 27, 2017
guide/src/class.md
Outdated
| @@ -61,6 +61,7 @@ python object that can be collector `PyGCProtocol` trait has to be implemented. | |||
| * `weakref` - adds support for python weak references | |||
| * `base=xxx.YYY` - use custom base class. It is not possible to call constructor | |||
| of base class at the moment. `xxx.YYY`, `xxx` - module name, `YYY` class name. | |||
| * `basetype` - adds subclass support | |||
There was a problem hiding this comment.
maybe something like "python classes can inherit from this class", otherwise it is not clear
fafhrd91
requested changes
Jul 27, 2017
|
Seem that some test cases are flaky. |
|
Yes, ref count related tests are flaky because Rust runs multiple tests in parallel. I will fix later |
fafhrd91
approved these changes
Jul 27, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ref #15