Support conversion between num-bigint <-> Python Long #608
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
birkenfeld
reviewed
Sep 29, 2019
src/types/num.rs
Outdated
| int_convert_128!(u128, 16, 0); | ||
|
|
||
| #[cfg(all(feature = "num-bigint", not(Py_LIMITED_API)))] | ||
| mod bitint_conversion { |
src/types/num.rs
Outdated
| if num.is_null() { | ||
| return Err(PyErr::fetch(ob.py())); | ||
| } | ||
| let n_bytes = (ffi::_PyLong_NumBits(ob.as_ptr()) as usize - 1) / 8 + 1; |
There was a problem hiding this comment.
looks like this should use num, not ob...
Can _PyLong_NumBits return zero? The subtract would wrap in that case.
There was a problem hiding this comment.
looks like this should use num, not ob...
Wow, I didn't know that.
Can _PyLong_NumBits return zero? The subtract would wrap in that case.
Good catch, thanks.
src/types/num.rs
Outdated
Comment on lines
235
to
238
| #[cfg(all(not(Py_LIMITED_API), target_endian = "little"))] | ||
| int_convert_128!(i128, 16, 1); | ||
| #[cfg(not(Py_LIMITED_API))] | ||
| int_convert_bignum!(i128, 16, IS_LITTLE_ENDIAN, 1); | ||
| #[cfg(not(Py_LIMITED_API))] | ||
| int_convert_bignum!(u128, 16, IS_LITTLE_ENDIAN, 0); | ||
| int_convert_128!(u128, 16, 0); |
There was a problem hiding this comment.
i128 conversions on big-endian appears to have been inadvertently deleted
There was a problem hiding this comment.
line 236 is only enabled on little-endian systems, so it can't provide the i128 conversions on big-endian systems since it is disabled.
There was a problem hiding this comment.
Ah, I understand.
Thank you for pointing it out!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #543.