Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Small fixes #4567

Merged
merged 3 commits into from
Oct 2, 2024
Merged

Small fixes #4567

merged 3 commits into from
Oct 2, 2024

Conversation

ahlinc
Copy link
Contributor

@ahlinc ahlinc commented Sep 19, 2024

This PR fixes a misprint in parse_stuct_args fn name and also fixes Rust compiler warning about non snake case method names on macro generated methods like __pymethod___setitem__.

Copy link
Member

@davidhewitt davidhewitt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, and sorry for the slow review! I took the liberty to push a CHANGELOG entry.

@davidhewitt davidhewitt enabled auto-merge October 1, 2024 20:58
@davidhewitt davidhewitt added this pull request to the merge queue Oct 1, 2024
Merged via the queue into PyO3:main with commit caa3c51 Oct 2, 2024
43 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants