use "fastcall" convention on abi3, if >3.10 #4415
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
davidhewitt
force-pushed
the
fastcall-abi3-310
branch
from
bd1266b to
381d42b
Compare
davidhewitt
force-pushed
the
fastcall-abi3-310
branch
from
381d42b to
b1d520f
Compare
|
Assuming this now passes CI, will probably merge as a straightforward improvement. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
METH_FASTCALLcalling convention is part ofabi3since 3.10, so this PR is updating our function calling conventions accordingly.At the same time I've pulled in the FFI definition
PyCFunctionFastandPyCFunctionFastWithKeywords, which have had their_Pyprefix adjusted to justPyin 3.13