Added as_super
and into_super
methods for Bound<T: PyClass>
#4351
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds two new methods to provide a more convenient mechanism for casting a
Bound
pyclass to its base type. The new methods mirror the corresponding methods forPyRef
andPyRefMut
(see #4219).Casting
Bound<T>
toBound<T::BaseType>
can be useful in the context of thePyMyClassMethods
idiom when an extension trait is use to implemented methods (for use from Rust) on theBound
version of a pyclass's base type. The upcast of a pyclass to its base type is a trivially safe operation, but making this cast is currently extremely verbose.For example, there are currently two options for casting
Bound<T>
toBound<T::BaseType
by value:Upcasting by reference is a bit less painful since you can leverage
Deref<Target=PyAny>
to avoid the first method call, but its still ugly and requires either anunwrap
or anunsafe
block.The new methods added by this PR make it much nicer: