Automated module= field creation in declarative modules #4213
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced May 27, 2024
Tpt
force-pushed
the
auto-module
branch
4 times, most recently
from
95da40e to
8f9358d
Compare
|
👍 thanks, I'll try to review later. Also, I find myself wanting to use declarative modules all the time so I'm tempted to call them stable once we merge this! 😁 |
davidhewitt
reviewed
May 28, 2024
| }; | ||
|
|
||
| #[derive(Default)] | ||
| pub struct PyModuleOptions { | ||
| krate: Option<CrateAttribute>, | ||
| name: Option<syn::Ident>, | ||
| module: Option<ModuleAttribute>, |
There was a problem hiding this comment.
This new attribute probably needs documenting in the guide.
There was a problem hiding this comment.
Done. Sorry for the huge lag
Sets automatically the "module" field of all contained classes and submodules in a declarative module Adds the "module" field to pymodule attributes in order to set the name of the parent modules. By default, the module is assumed to be a root module
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Sets automatically the "module" field of all contained classes and submodules in a declarative module
Adds the "module" field to
#[pymodule]attributes in order to set the name of the parent module. By default, the module is assumed to be a root module.