Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

async method should allow args not only receiver #4015

Merged
merged 2 commits into from
Mar 30, 2024
Merged

async method should allow args not only receiver #4015

merged 2 commits into from
Mar 30, 2024

Conversation

reswqa
Copy link
Contributor

@reswqa reswqa commented Mar 29, 2024 •
edited
Loading

Playing with procedural macros for the first time, so any comments/suggestions are welcome.

This fixes #4005.

@reswqa reswqa marked this pull request as ready for review March 29, 2024 14:51
davidhewitt
davidhewitt approved these changes Mar 30, 2024
View reviewed changes
Copy link
Member

@davidhewitt davidhewitt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, this looks like the correct fix to me 👍

@davidhewitt davidhewitt added this pull request to the merge queue Mar 30, 2024
Merged via the queue into PyO3:main with commit 74d9d23 Mar 30, 2024
44 of 45 checks passed
@reswqa reswqa deleted the async_args branch March 30, 2024 12:31
@davidhewitt davidhewitt mentioned this pull request Apr 2, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@davidhewitt davidhewitt davidhewitt approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Async pymethod with receiver can not pass any other arguments
2 participants
@reswqa @davidhewitt