implement Send and Sync for PyBackedStr and PyBackedBytes
#4007
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
davidhewitt
force-pushed
the
backed-send-sync
branch
from
1226d3c to
86b0042
Compare
davidhewitt
force-pushed
the
backed-send-sync
branch
from
86b0042 to
111f160
Compare
LilyFoote
approved these changes
Mar 28, 2024
adamreichold
approved these changes
Mar 29, 2024
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
|
PyPy fix can't come soon enough :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I noticed while working on my PyO3 tutorial today that the
PyBackedStrandPyBackedBytestypes do not implementSendorSync, because they have aNonNullpointer inside them.I think it should be perfectly safe to implement
SendandSynchere, because these types are immutable and thePysmart pointer is alreadySendandSync.