release: 0.19.2 #3348
Merged
release: 0.19.2 #3348
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When the Python iterator backing `PyIterator` has a `__length_hint__` special method, we can use this as a lower bound for Rust's `Iterator::size_hint` to e.g. support pre-allocation of collections. This is implemented using `PyObject_LengthHint` which is not available in the stable ABI and hence so is `Iterator::size_hint`. This should be fine since this is an optimization in any case and the stable ABI is expected to have slightly worse performance overall.
davidhewitt
added
CI-no-fail-fast
davidhewitt
force-pushed
the
release-0.19.2
branch
from
ac67f7e to
a832227
Compare
davidhewitt
force-pushed
the
release-0.19.2
branch
from
a832227 to
931e23d
Compare
|
🎉 this is all green, finally! CHANGELOG / version bump update also pushed. I'll move forwards with releasing this on Tuesday unless I hear a reason to wait. |
|
Release is live! |
|
Thank you for your work on this! I'll push this to Fedora ASAP, and will try to move some pyo3 users to this from old versions (< 0.19). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I think we're almost ready to release a 0.19.2 patch release to improve compatibility with 3.12.
Closes #3305
cc @decathorpe
I'd like to get just a few last PRs approved and merged before releasing; I will then cherry-pick them and go through the motions of the version bump / CHANGELOG prep in this PR:
float->f64conversions on non-abi3 #3345