Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix **kwargs #328

Merged
merged 1 commit into from
Jan 28, 2019
Merged

Fix **kwargs #328

merged 1 commit into from
Jan 28, 2019

Conversation

Alexander-N
Copy link
Member

@Alexander-N Alexander-N commented Jan 24, 2019

**kwargs was broken by a check for the number of given arguments. Only
apply this check if no arbitrary number of keyword arguments are allowed
by a "**" parameter of #[args(...).

Closes #318

kwargs was broken by a check for the number of given arguments. Only
apply this check if no arbitary number of keyword arguments are allowed
by a "**" parameter of `#[args(...)`.

Closes PyO3#318
Copy link
Member

@kngwyu kngwyu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@kngwyu
Copy link
Member

kngwyu commented Jan 28, 2019

Thanks 👍

@kngwyu kngwyu merged commit 20dbf54 into PyO3:master Jan 28, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants