Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Extend lifetime of GIL token associated with PyRef(Mut). #3131

Merged
merged 1 commit into from
May 4, 2023

Conversation

adamreichold
Copy link
Member

No description provided.

@adamreichold adamreichold force-pushed the pyref-python-token branch from 912b9e4 to 63a9093 Compare May 1, 2023 18:57
Copy link
Member

@mejrs mejrs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm, the docs need fixing though.

src/pycell.rs Show resolved Hide resolved
src/pycell.rs Show resolved Hide resolved
Copy link
Member

@davidhewitt davidhewitt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! Agree with @adamreichold that this aligns the implementation with the original documentation.

@adamreichold
Copy link
Member Author

bors r=mejrs

@bors
Copy link
Contributor

bors bot commented May 4, 2023

Build succeeded!

The publicly hosted instance of bors-ng is deprecated and will go away soon.

If you want to self-host your own instance, instructions are here.
For more help, visit the forum.

If you want to switch to GitHub's built-in merge queue, visit their help page.

@bors bors bot merged commit 22e77b0 into main May 4, 2023
@bors bors bot deleted the pyref-python-token branch May 4, 2023 12:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants