Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update memoffset, send_wrapper and hashbrown #2875

Merged
merged 5 commits into from
Jan 12, 2023
Merged

Update memoffset, send_wrapper and hashbrown #2875

merged 5 commits into from
Jan 12, 2023

Conversation

messense
Copy link
Member

No description provided.

adamreichold
adamreichold reviewed Jan 11, 2023
View reviewed changes
noxfile.py Outdated Show resolved Hide resolved
@messense messense force-pushed the update-deps branch 2 times, most recently from 0fa8485 to 78db33b Compare January 12, 2023 03:16
@messense
Copy link
Member Author

bors try

bors bot added a commit that referenced this pull request Jan 12, 2023
@bors
Try #2875:
5e45c68
@bors
Copy link
Contributor

bors bot commented Jan 12, 2023

try

Build succeeded:

@adamreichold
Copy link
Member

Still needs a changelog entry.

adamreichold
adamreichold reviewed Jan 12, 2023
View reviewed changes
noxfile.py Outdated Show resolved Hide resolved
messense added a commit to messense/pyo3 that referenced this pull request Jan 12, 2023
@messense
Add a changelog entry for PyO3#2875
52d153f
adamreichold
adamreichold reviewed Jan 12, 2023
View reviewed changes
noxfile.py Outdated Show resolved Hide resolved
adamreichold
adamreichold approved these changes Jan 12, 2023
View reviewed changes
Copy link
Member

@adamreichold adamreichold left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for going the extra mile on the minimal-versions Nox session!

The nits on the Python code are merely that, so LGTM.

@adamreichold
Copy link
Member

bors r+

@bors
Copy link
Contributor

bors bot commented Jan 12, 2023

Build succeeded:

@bors bors bot merged commit ed0f338 into PyO3:main Jan 12, 2023
@messense messense deleted the update-deps branch January 12, 2023 06:51
@davidhewitt
Copy link
Member

This looks great, many thanks both!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@adamreichold adamreichold adamreichold approved these changes

Assignees
No one assigned
Labels
dependencies
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@messense @adamreichold @davidhewitt