Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Python 3.7 support for PyCodeObject. #2726

Merged
merged 3 commits into from
Nov 8, 2022

Conversation

itamarst
Copy link
Contributor

@itamarst itamarst commented Nov 8, 2022

See https://github.com/python/cpython/blob/3.7/Include/code.h#L21 for the original C code for validation.

Fixes #2725

Copy link
Member

@davidhewitt davidhewitt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for identifying & fixing this!

@davidhewitt davidhewitt linked an issue Nov 8, 2022 that may be closed by this pull request
@davidhewitt davidhewitt enabled auto-merge (squash) November 8, 2022 20:33
@itamarst
Copy link
Contributor Author

itamarst commented Nov 8, 2022

Is there any ETA for next release, BTW? Or should I just rely on git version for now?

@davidhewitt
Copy link
Member

Good question, maybe next month or so? So if you need sooner, git is the way to go I'm afraid.

@davidhewitt davidhewitt merged commit 6746ff8 into PyO3:main Nov 8, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

PyCodeObject does not define fields on Python 3.7
3 participants