Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add super object #2486

Merged
merged 9 commits into from
Jul 3, 2022
Merged

Add super object #2486

merged 9 commits into from
Jul 3, 2022

Conversation

ikrivosheev
Copy link
Contributor

Hello! this PR close: #2049

  • an entry in CHANGELOG.md
  • docs to all new functions and / or detail in the guide
  • tests for all new or changed functions

davidhewitt
davidhewitt reviewed Jun 28, 2022
View reviewed changes
Copy link
Member

@davidhewitt davidhewitt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Many thanks for working on this! I think there's a few bits which need to be tidied up, see comments below.

tests/test_super.rs Outdated Show resolved Hide resolved
tests/test_super.rs Outdated Show resolved Hide resolved
src/types/pysuper.rs Outdated Show resolved Hide resolved
src/types/pysuper.rs Outdated Show resolved Hide resolved
src/types/pysuper.rs Outdated Show resolved Hide resolved
@ikrivosheev ikrivosheev requested a review from davidhewitt June 29, 2022 11:04
@ikrivosheev
Copy link
Contributor Author

Many thanks for working on this! I think there's a few bits which need to be tidied up, see comments below.

@davidhewitt thank you for review! I fix some comments but I have one question: #2486 (comment)

davidhewitt
davidhewitt reviewed Jul 3, 2022
View reviewed changes
Copy link
Member

@davidhewitt davidhewitt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the amendments - I've given this another read and got a few final suggestions.

I think you will also need to add #[cfg(not(PyPy))] to this file - it looks like PyPy does not have the C APIs needed for this.

tests/test_super.rs Outdated Show resolved Hide resolved
src/types/pysuper.rs Outdated Show resolved Hide resolved
@ikrivosheev ikrivosheev requested a review from davidhewitt July 3, 2022 16:58
@ikrivosheev
Copy link
Contributor Author

@davidhewitt thank you for review! I have done with comment)

davidhewitt
davidhewitt approved these changes Jul 3, 2022
View reviewed changes
Copy link
Member

@davidhewitt davidhewitt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Many thanks, this looks great to me now!

@davidhewitt davidhewitt merged commit 1cd1dbf into PyO3:main Jul 3, 2022
@ikrivosheev ikrivosheev deleted the feature/issues-2049_super branch July 3, 2022 18:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@davidhewitt davidhewitt davidhewitt approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Bindings for super()
2 participants
@ikrivosheev @davidhewitt