macros: simpler expansion for intern!
#2413
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
adamreichold
approved these changes
Jun 1, 2022
|
Does this implementation continue to forbid patterns like #2269 (comment)? I think that the const-ness of |
I think so too, though I'll add a test to be sure. |
davidhewitt
force-pushed
the
simpler-interned
branch
from
7d909ca to
4ea80c6
Compare
davidhewitt
force-pushed
the
simpler-interned
branch
from
4ea80c6 to
ede6439
Compare
davidhewitt
force-pushed
the
simpler-interned
branch
from
ede6439 to
261c0c5
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds a helper
Internedstruct to contain the implementation of theintern!macro. Simplifies the expanded code a little, should allow the compiler to re-use the one monomorphization ofget_or_init.