pyo3-build-config: Inline the PYO3_NO_PYTHON switch
#2276
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This patch folds the `PYO3_NO_PYTHON` + `abi3` special case into the existing native and cross compilation code paths. The cross compilation route is now guaranteed to behave the same whether `PYO3_NO_PYTHON` is set or not (except for sysconfigdata discovery for the Unix targets). The native compilation route now stores the hardcoded abi3 interpreter configuration in place of the discovered configuration blob.
davidhewitt
approved these changes
Apr 6, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This patch folds the
PYO3_NO_PYTHON+abi3special case intothe existing native and cross compilation code paths.
The cross compilation route is now guaranteed to behave the same
whether
PYO3_NO_PYTHONis set or not (except for sysconfigdatadiscovery for the Unix targets).
The native compilation route now stores the hardcoded abi3 interpreter
configuration in place of the discovered configuration blob.
Still working to pave the way for #2231