macros: optimize generated code for #[derive(FromPyObject)] #2068
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Inspired by #1966, I decided to take a look at the generated code for
#[derive(FromPyObject)]
for enums.There seemed to be some pretty easy wins as well as fixes to error messages, so I just went ahead and made them. Mostly what I did is delay all string formatting until creation of the final error message, to avoid intermediate costs when the conversion still ultimately succeeds. To keep generated code smaller I also extracted this into a
#[cold]
helper function that gets re-used for all enum derive implementations.Added a benchmark for a simple enum case; it shows quite significant wins:
... there's probably more that can be done here to improve the other generated code from this macro too; this is enough for today.