Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

review sysconfigdata filename match rules to support cp37m #1908

Merged
merged 1 commit into from
Oct 12, 2021

Conversation

gi0baro
Copy link
Contributor

@gi0baro gi0baro commented Oct 12, 2021

As per title, on cp37-cp37m sysconfigdata file name is in the form _sysconfigdata_m_linux_x86_64-linux-gnu.py.

This review the change introduced with 4a6ea17#diff-5f4a9955ffbc1038032f0905b2fb70e7dbd991e489532e4529fe14a576aa0a25R915, allowing also sysconfigdata files in the form _sysconfigdata_m_* rather than forcing only the modern _sysconfigdata__.

@davidhewitt davidhewitt force-pushed the sysconfigdata-match-cp37m branch from 7e31974 to c060588 Compare October 12, 2021 22:41
Copy link
Member

@davidhewitt davidhewitt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 thanks, I've added a CHANGELOG entry!

@davidhewitt davidhewitt enabled auto-merge October 12, 2021 22:42
@davidhewitt davidhewitt merged commit acb3879 into PyO3:main Oct 12, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants