guide: rewrite "Building and Distribution" chapter #1749
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
messense
reviewed
Aug 1, 2021
davidhewitt
force-pushed
the
building-distribution-rewrite
branch
from
9c5b388
to
a1f23c9
Compare
davidhewitt
commented
Aug 1, 2021
birkenfeld
reviewed
Aug 1, 2021
davidhewitt
force-pushed
the
building-distribution-rewrite
branch
from
3f0242f
to
725fecf
Compare
davidhewitt
force-pushed
the
building-distribution-rewrite
branch
from
725fecf
to
582d9c5
Compare
birkenfeld
approved these changes
Aug 1, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In preparation for documenting changes for #1719, I ended up rewriting the "building and distribution" chapter of the guide.
It's mostly a reorganisation and extra text to make it flow a bit better.
I ended up taking out the "PyPy" section as I don't think it's particularly informative. Our docs already have information on all APIs which aren't available for PyPy e.g. https://docs.rs/pyo3/0.14.1/pyo3/types/struct.PyDict.html#method.from_sequence, which seems good enough and much more likely to stay up-to-date than a list in the guide.