Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

rust: updates for rust & clippy 1.54 #1745

Merged
merged 3 commits into from
Jul 31, 2021
Merged

Conversation

davidhewitt
Copy link
Member

No description provided.

@davidhewitt
Copy link
Member Author

Windows 32-bit segfault is because dictoffset in the PyCell seems to be calculated incorrectly. I think the types in pyclass_slots.rs need to be #[repr(C)], will confirm when I get home later

@davidhewitt davidhewitt force-pushed the rust-1.54 branch 2 times, most recently from b850836 to 6b5eb1f Compare July 31, 2021 12:56
@davidhewitt
Copy link
Member Author

Looks like we calculated dictoffset incorrectly on 32-bit windows. The dictoffset was resolving to the padding bytes at the end of the PyCell struct. I guess that Rust 1.54 might have stopped zero-initialising the padding (or vice versa?) which caused the crash to become noticeable.

I've replaced the offset calculations with more robust ones.

@davidhewitt davidhewitt force-pushed the rust-1.54 branch 7 times, most recently from 50cf382 to ad309d2 Compare July 31, 2021 14:08
@birkenfeld
Copy link
Member

Sounds like this should be released as 0.14.2?

@davidhewitt
Copy link
Member Author

Yes, I'm going to open a PR to fix #1719 and then prepare the full lot as 0.14.2 release. (Hopefully today, depending on some family stuff I've got to do first)

@davidhewitt davidhewitt deleted the rust-1.54 branch July 31, 2021 15:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants