Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix memory leak when converting to u128 and i128 #1638

Merged
merged 2 commits into from
May 26, 2021
Merged

Conversation

erikjohnston
Copy link
Contributor

I had a quick look at the equivalent slow_128bit_int_conversion conversion and I don't think there is a leak there, but I haven't checked.

Copy link
Member

@birkenfeld birkenfeld left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, nice find!

@messense messense merged commit 49e67d7 into PyO3:main May 26, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants