Don't require PYO3_CROSS_LIB_DIR when compiling for x86_64 from macOS arm64 and reverse #1428
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
davidhewitt
reviewed
Feb 14, 2021
… arm64 and reverse
messense
force-pushed
the
macos-arm64-cross
branch
from
91e70cf to
ebc52c4
Compare
messense
changed the title
|
Thanks! Will get to the setuptools-rust PRs later this afternoon. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Big Sur nows ships universal2 binary for Python and Xcode, no need to use
PYO3_CROSS_LIB_DIRwhen compiling for x86_64 from macOS arm64.I think it's also the same when compiling for arm64 from x86-64 macOS but it would require checking Xcode version(at least 12.2? I'm not sure).
cc PyO3/maturin#405 (comment)