Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

pyclass: fix deprecation warning for no __module__ attribute #1343

Merged
merged 1 commit into from
Dec 28, 2020
Merged

pyclass: fix deprecation warning for no __module__ attribute #1343

merged 1 commit into from
Dec 28, 2020

Conversation

davidhewitt
Copy link
Member

Closes #1298 .

This ensures that __module__ is always set (usually to "builtins", which is consistent with what we already do).

kngwyu
kngwyu approved these changes Dec 28, 2020
View reviewed changes
Copy link
Member

@kngwyu kngwyu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice catch, thank you!

@kngwyu kngwyu merged commit 97bf075 into PyO3:master Dec 28, 2020
@davidhewitt davidhewitt deleted the module-attribute branch August 10, 2021 07:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kngwyu kngwyu kngwyu approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

DeprecationWarning: builtin type X has no __module__ attribute
2 participants
@davidhewitt @kngwyu