Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add PyEval_SetProfile, PyEval_SetTrace #1255

Merged
merged 1 commit into from
Oct 21, 2020

Conversation

aviramha
Copy link
Member

@aviramha aviramha commented Oct 20, 2020

Not sure if I missed anything, I relied on existing infra to understand what needs to be done.
Feedback will be appreciated.

@aviramha aviramha force-pushed the add_profiling_functions branch 2 times, most recently from 8718640 to 66ff223 Compare October 20, 2020 19:46
@kngwyu
Copy link
Member

kngwyu commented Oct 21, 2020

Thanks!
Could you please consider placing those on ceval.rs since they are originally in ceval.h?
Also, it would be better if we have

pub type Py_tracefunc = extern "C" fn(
    obj: *mut PyObject,
    frame: *mut PyFrameObject,
    what: c_int,
    arg: *mut PyObject,
) -> c_int;

in pystate.rs.

@aviramha
Copy link
Member Author

@kngwyu Thanks for the review! I tried to do what you have suggested but have failed due to lack of Rust/FFI experience 👍
I'll change it ASAP.

@aviramha aviramha force-pushed the add_profiling_functions branch from 66ff223 to 7baa89e Compare October 21, 2020 07:47
@aviramha
Copy link
Member Author

Done!

Copy link
Member

@kngwyu kngwyu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@kngwyu kngwyu merged commit 33a602d into PyO3:master Oct 21, 2020
@aviramha aviramha deleted the add_profiling_functions branch October 21, 2020 10:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants