Don't consider it cross-compilation when building for 32-bit Windows on 64-bit windows #1179
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…on 64-bit windows
|
Thanks, nice catch. I thought our CI would catch this when I commented it seemed a possible breakage in #1095, but at the time CI suggested it was ok (and I was suprised but let it slide). Can you add a CHANGELOG entry please? (fixed section) I will rebase the setuptools-rust github actions CI PR I had, which I guess will find the same issue. Might give this a couple days once merged before releasing just so that 0.12.1 can include fixes for any other painful oversights! |
|
Added a changelog entry. Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a bit of an untested hack :-)
In PyO3/setuptools-rust#77 we introduced the ability to automatically build for 32-bit Windows when running a 32-bit Python on a 64-bit Windows (and Rust toolchain). The 0.12 release of pyo3 unfortunately broke this. I believe this PR may resolve it.