Allow importing exceptions from nested modules #116
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some exceptions are not available in a top-level Python namespace (for instance exceptions defined in
email.errors
) but the current implementation of theimport_exception
macro didn't allow for dotted module names.I added a macro to stringify a dotted path (
dot_stringify!(a.b.c) => "a.b.c"
) and used to fix theimport_exception
macro. It's backward compatible with the current implementation.As a test, I left the current test but added a test with
MessageError
exception from theemail.errors
module (which is available in the standard library of all Python version this library supports).