Allow borrowed object for PyTuple::get_item.

As per feedback on #890
PyO3 · May 3, 2020 · 1579307 · 1579307
1 parent b7ecec7
commit 1579307
Showing 1 changed file with 1 addition and 4 deletions.
diff --git a/src/types/tuple.rs b/src/types/tuple.rs
@@ -72,10 +72,7 @@ impl PyTuple {
     pub fn get_item(&self, index: usize) -> &PyAny {
         assert!(index < self.len());
         unsafe {
-            // PyTuple_GET_ITEM return borrowed ptr; must make owned for safety (see #890).
-            let ptr = ffi::PyTuple_GET_ITEM(self.as_ptr(), index as Py_ssize_t);
-            ffi::Py_INCREF(ptr);
-            self.py().from_owned_ptr(ptr)
+            self.py().from_owned_ptr(ffi::PyTuple_GET_ITEM(self.as_ptr(), index as Py_ssize_t))
         }
     }