Add support for wasm32-unknown-emscripten target
#974
Merged
+327
−29
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for maturin-guide ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
messense
commented
Jun 19, 2022
messense
force-pushed
the
emscripten
branch
5 times, most recently
from
fb7e327 to
26a029b
Compare
hoodmane
reviewed
Jun 19, 2022
hoodmane
reviewed
Jun 19, 2022
.github/workflows/test.yml
Outdated
| run: | | ||
| set -ex | ||
| cargo run build -m test-crates/pyo3-mixed/Cargo.toml -o dist --target wasm32-unknown-emscripten -i python3.11 | ||
| # TODO: Install Pyodide and run tests |
There was a problem hiding this comment.
We should make at least an alpha release of Pyodide since installing the development version is a bit inconvenient. It's also been longer than normal since we made a release.
messense
force-pushed
the
emscripten
branch
2 times, most recently
from
50374b7 to
510dba8
Compare
hoodmane
reviewed
Jun 19, 2022
src/compile.rs
Outdated
| @@ -214,6 +218,22 @@ fn compile_target( | |||
| ]; | |||
| rustc_args.extend(mac_args); | |||
| } | |||
| } else if target.is_emscripten() { | |||
| shared_args.push("-Zbuild-std"); | |||
There was a problem hiding this comment.
Hopefully rust-lang/rust#98149 will be merged soon and we won't have to use this.
There was a problem hiding this comment.
When that happens we can also remove -Crelocation_model=pic.
hoodmane
reviewed
Jun 19, 2022
|
Thanks for working on this @messense! |
|
Thanks for the review and your work on |
Co-authored-by: Hood Chatham <[email protected]>
2 tasks
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
TODO:
The workaround was removed in Emscripten: Use -Z link-native-libraries=no and remove emcc wrapper #978
Part of #904