Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix abi3 wheel build issue when no Python interpreters found on host #933

Merged
merged 1 commit into from
May 21, 2022

Conversation

messense
Copy link
Member

@messense messense commented May 21, 2022

Fixes the following issue.

maturin.exe build -m maturin/test-crates/pyo3-pure/Cargo.toml --zig --target aarch64-unknown-linux-gnu
πŸ”— Found pyo3 bindings with abi3 support for Python β‰₯ 3.7
🐍 Not using a specific python interpreter
πŸ“‘ Using build options bindings from pyproject.toml
πŸ“¦ Built source distribution to D:\a\maturin-action\maturin-action\maturin\test-crates\pyo3-pure\target\wheels\pyo3_pure-2.1.2.tar.gz
thread 'main' panicked at 'assertion failed: !wheels.is_empty()', src\main.rs:337:13
stack backtrace:
note: Some details are omitted, run with `RUST_BACKTRACE=full` for a verbose backtrace.

for

if !cpythons.is_empty() {
built_wheels.extend(self.build_binding_wheel_abi3(&cpythons, *major, *minor)?);
}

We should refactor the whole python interpreters detection logic later, we have used several faking interpreters for similar purposes now.

@netlify
Copy link

netlify bot commented May 21, 2022

βœ… Deploy Preview for maturin-guide canceled.

Name Link
πŸ”¨ Latest commit 400d67a
πŸ” Latest deploy log https://app.netlify.com/sites/maturin-guide/deploys/6288eb695c92c200089c09ef

@messense messense changed the title Fix build issue when no Python interpreters found on host Fix abi3 wheel build issue when no Python interpreters found on host May 21, 2022
@messense messense merged commit 3c81e4c into PyO3:main May 21, 2022
@messense messense deleted the fix-zero-wheels branch May 21, 2022 14:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant