Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use setuptools-rust for bootstrapping #909

Merged
merged 1 commit into from
May 11, 2022

Conversation

jameshilliard
Copy link
Contributor

This seems like a better approach for bootstrapping and fixes things so that the extensions are built during the build phase instead of the install phase.

@netlify
Copy link

netlify bot commented May 10, 2022

Deploy Preview for maturin-guide canceled.

Name Link
🔨 Latest commit a5a139a
🔍 Latest deploy log https://app.netlify.com/sites/maturin-guide/deploys/6279d59286e6b40009fe4fd2

This seems like a better approach for bootstrapping and fixes things
so that the extensions are built during the build phase instead of
the install phase.

Signed-off-by: James Hilliard <[email protected]>
Copy link
Member

@messense messense left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, @konstin what do you think?

@messense messense merged commit fab9df0 into PyO3:main May 11, 2022
@jameshilliard jameshilliard deleted the setuptools-rust branch May 11, 2022 08:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants