Fix license line ending in wheel metadata for Windows #836
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
✔️ Deploy Preview for maturin-guide canceled. 🔨 Explore the source changes: de75834 🔍 Inspect the deploy log: https://app.netlify.com/sites/maturin-guide/deploys/62276b18fa448e0007a4f6b4 |
messense
commented
Mar 8, 2022
| let mut lines = license.split_inclusive('\n'); | ||
| assert_eq!( | ||
| lines.next().unwrap(), | ||
| "Copyright (c) 2018-present konstin\r\n" |
There was a problem hiding this comment.
Without trim_end(), this becomes Copyright (c) 2018-present konstin\r\r\n on Windows.
https://github.com/messense/maturin/runs/5465287747?check_suite_focus=true
messense
force-pushed
the
fix-windows-metadata
branch
from
f9bf3bb to
f237c38
Compare
anthrotype
added a commit
to anthrotype/pngquant-wheels
that referenced
this pull request
Mar 9, 2022
anthrotype
added a commit
to anthrotype/pngquant-wheels
that referenced
this pull request
Mar 9, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #829 (comment)