-
-
Notifications
You must be signed in to change notification settings - Fork 278
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support pyo3-ffi #804
Support pyo3-ffi #804
Conversation
✔️ Deploy Preview for maturin-guide canceled. 🔨 Explore the source changes: 14e5227 🔍 Inspect the deploy log: https://app.netlify.com/sites/maturin-guide/deploys/62037d60c55170000831ce3e |
"You have selected the `abi3` feature but not a minimum version (e.g. the `abi3-py36` feature). \ | ||
maturin needs a minimum version feature to build abi3 wheels." | ||
) | ||
for &lib in PYO3_BINDING_CRATES.iter() { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I looked at refactoring to BridgeModel::Bindings::Pyo3
and BridgeModel::Bindings::Pyo3Ffi
but it was a much larger change.
I've tested this on orjson and a test crate |
These places should also take |
We can use git dependency for pyo3-ffi. |
Co-authored-by: messense <[email protected]>
Thank you @ijl ! |
v0.12.10_beta.1 is out for testing. |
Thanks for fixing it up and merging. |
No description provided.