Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[win-arm64] Build without rustls package #674

Merged
merged 3 commits into from
Nov 10, 2021
Merged

[win-arm64] Build without rustls package #674

merged 3 commits into from
Nov 10, 2021

Conversation

niyas-sait
Copy link
Contributor

Build without rustls package as ring dependency is missing win/arm64 support.

@netlify
Copy link

netlify bot commented Nov 10, 2021 •
edited
Loading

✔️ Deploy Preview for maturin-guide canceled.

🔨 Explore the source changes: c1a303f

🔍 Inspect the deploy log: https://app.netlify.com/sites/maturin-guide/deploys/618bc69d2a108a00078af2bd

messense
messense reviewed Nov 10, 2021
View reviewed changes
Copy link
Member

@messense messense left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, I think ring will have Windows arm64 support in the next release and rustls maybe able to support it too. But for now it's ok to disable rustls for it.

setup.py Outdated Show resolved Hide resolved
@messense messense merged commit 0535efe into PyO3:main Nov 10, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@messense messense messense approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@niyas-sait @messense