-
-
Notifications
You must be signed in to change notification settings - Fork 277
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add path option for Python source #584
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
FIXME: It's wrong, see 41a49b6pyproject.toml
should be relative to Python source instead of Cargo.toml
.
7220fd7
to
2750d9f
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍 This seems like a good idea, it's nice to give users this flexibility!
(This looks good to me, apart from missing README. I would approve, but historically I haven't been an approver / reviewer for maturin. If you want more review capacity I'm happy to start reviewing & approving maturin PRs?) |
That would be great. konstin emailed me that he won't be actively maintain maturin nowaday. |
Co-authored-by: David Hewitt <[email protected]>
@messense I'm on Windows 10, Python 3.8 and using Maturin 0.11.3-beta.2. I can't seem to get Any ideas? |
@ShanWeera Can you share the cargo.toml which doesn't work? |
@ShanWeera Please open a new issue so we can track it. |
https://build.opensuse.org/request/show/922513 by user mia + dimstar_suse - Update to 0.11.4 * Autodetect PyPy executables gh#PyO3/maturin#617 * auditwheel: add `libz.so.1` to whitelisted libraries gh#PyO3/maturin#625 * auditwheel: detect musl libc gh#PyO3/maturin#629 * Fixed Python 3.10 and later versions detection on Windows gh#PyO3/maturin#630 * Install entrypoint scripts in `maturin develop` command gh#PyO3/maturin#633 gh#PyO3/maturin#634 * Add support for installing optional dependencies in `maturin develop` command gh#PyO3/maturin#635 * Fixed build error when `manylinux`/`compatibility` options is specified in `pyproject.toml` gh#PyO3/maturin#637 - Changes in 0.11.3: * Add path option for Python source gh#PyO3/maturin#584 * Add auditwheel support for musllinux gh#PyO3/maturin#597 * `[tool.m
With this PR you can specify Python source code location in
Cargo.toml
by settingpackage.metadata.maturin.python-source
to your Python source code directory.Here is an example project layout with
python-source
set topython
:Closes #335