Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support i386 on OpenBSD #568

Merged
merged 2 commits into from Jun 16, 2021
Merged

Support i386 on OpenBSD #568

merged 2 commits into from Jun 16, 2021

Conversation

ghost
Copy link

@ghost ghost commented Jun 15, 2021

Compiling py-adblock on OpenBSD-i386, rust 1.52.1, python 3.8.8 breaks up with the following error

i686 is not supported on OpenBSD

The given patch allows building with the above configuration. Currently building py-adblock has been the extent of testing maturin has undergone on i386. Let me know if there is anything more to add.

@konstin
Copy link
Member

konstin commented Jun 15, 2021

Please add an entry in the changelog, otherwise this looks good

Copy link
Member

@messense messense left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@messense messense merged commit 4a61dca into PyO3:main Jun 16, 2021
@ghost ghost mentioned this pull request Jun 17, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants