Merge metadata with project table in pyproject.toml #555
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
messense
commented
May 29, 2021
src/metadata.rs
Outdated
| pyproject_toml: &PyProjectToml, | ||
| manifest_path: impl AsRef<Path>, | ||
| ) -> Result<()> { | ||
| // FIXME: where to find `pyproject.toml`? relative to manifest_path? relative to working directory? |
There was a problem hiding this comment.
I'm opening this draft PR for discussion.
@konstin what's your thought about this?
messense
commented
May 30, 2021
messense
force-pushed
the
pep621
branch
3 times, most recently
from
23bd20a to
d0de556
Compare
messense
force-pushed
the
pep621
branch
5 times, most recently
from
291583f to
ceebb53
Compare
konstin
reviewed
May 31, 2021
| @@ -136,7 +306,7 @@ impl Metadata21 { | |||
| .package | |||
| .keywords | |||
| .clone() | |||
| .map(|keywords| keywords.join(" ")), | |||
| .map(|keywords| keywords.join(",")), | |||
Co-authored-by: konstin <[email protected]>
https://packaging.python.org/specifications/core-metadata/#keywords The specification previously showed keywords separated by spaces, but distutils and setuptools implemented it with commas. These tools have been very widely used for many years, so it was easier to update the specification to match the de facto standard.
…ers` https://packaging.python.org/specifications/core-metadata/#classifier-multiple-use I've downloaded `Flask` and `requests` from PyPI, they all show `Classifier` in wheel metadata
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #465