-
-
Notifications
You must be signed in to change notification settings - Fork 278
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
auditwheel choose higher priority tag when possible #456
Conversation
93e8822
to
d29523c
Compare
d29523c
to
d11a4c9
Compare
.is_ok() | ||
{ | ||
println!( | ||
"📦 Wheel is eligible for a higher priority tag. You requested {} but I have found this wheel is eligible for {}", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is great 👍
I think the ideal solution would be having three categories:
There might be a case for a fourth option, This PR is already a huge improvement as-is, so I'm happy with merging this now and figuring out the specifics of the cli arguments later |
Sure, let's do that later in #448 |
Do you mean |
Oops, yes that should have been |
Example: