Support arm7l, aarch64 architectures and manylinux2014 tag #273
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The architecture, wheel names, and shared object names match what is specified in CPython and pip. arm7l and aarch64 are supported for Linux only. Target::from_target_triple() returns an Err on an unsupported OS and architecture combination. This allows building arm7l and aarch64 on manylinux1 and manylinux2010, which should not work in pip. Target::from_target_triple() could be expanded to error on this but that needs more refactoring than seems appropriate here.
Closed
|
Thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The architecture, wheel names, and shared object names
match what is specified in CPython and pip.
arm7l and aarch64 are supported for Linux only.
Target::from_target_triple() returns an Err on an
unsupported OS and architecture combination.
This allows building arm7l and aarch64 on manylinux1 and
manylinux2010, which should not work in pip.
Target::from_target_triple() could be expanded to error
on this but that needs more refactoring than seems
appropriate here.
#237