Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update goblin to 0.9 #2284

Merged
merged 3 commits into from
Oct 30, 2024
Merged

Update goblin to 0.9 #2284

merged 3 commits into from
Oct 30, 2024

Conversation

musicinmybrain
Copy link
Contributor

The breaking change from 0.8.0 appears to be the addition of a value to a pub enum associated with TE (terse executable) support; this does not look like it should affect maturin’s usage of goblin since it doesn’t match exhaustively on this enum.

https://github.com/m4b/goblin/blob/d096260201158ed34d64728fd1ab0ca125e2f956/CHANGELOG.md#092----2024-10-26

I’ve also filed PR’s for both of the crates that are still asking for goblin 0.8.0 in maturin’s dependency tree:

The breaking change from 0.8.0 appears to be the addition of a value to
a pub enum associated with TE (terse executable) support; this does not
look like it should affect maturin’s usage of goblin since it doesn’t
match exhaustively on this enum.

https://github.com/m4b/goblin/blob/d096260201158ed34d64728fd1ab0ca125e2f956/CHANGELOG.md#092----2024-10-26
@musicinmybrain musicinmybrain changed the title Update goblin to 0.9.0 Update goblin to 0.9 Oct 30, 2024
Copy link
Member

@konstin konstin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks

@konstin konstin enabled auto-merge (squash) October 30, 2024 11:52
@messense
Copy link
Member

Could you please also update related deps now that I've release new versions? Thanks!

@messense messense disabled auto-merge October 30, 2024 11:54
- Now Cargo.lock contains only goblin 0.9; nothing requires goblin 0.8
@musicinmybrain
Copy link
Contributor Author

Could you please also update related deps now that I've release new versions? Thanks!

Yes, I missed that you had already released! Pushing now.

@messense messense enabled auto-merge (squash) October 30, 2024 12:03
@messense messense merged commit dbe456b into PyO3:main Oct 30, 2024
32 of 35 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants