Initial iOS support #2102
Merged
Initial iOS support #2102
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for maturin-guide ready!Built without sensitive environment variables
To edit notification comments on pull requests, go to your Netlify site configuration. |
messense
approved these changes
Jun 6, 2024
What are the correct wheel tags? |
Closed
netbsd-srcmastr
pushed a commit
to NetBSD/pkgsrc
that referenced
this pull request
Jul 19, 2024
## [1.7.0] - 2024-07-07 * Initial iOS support in [#2101](PyO3/maturin#2102) * Remove old import hook in [#2105](PyO3/maturin#2105), use [maturin-import-hook](https://github.com/PyO3/maturin-import-hook) instead * Bump MSRV to 1.74.0 in [#2108](PyO3/maturin#2108) * Add support for overriding wheel tag with `_PYTHON_HOST_PLATFORM` in [#2122](PyO3/maturin#2122) * Don't add files to an archive more than once [#2125](PyO3/maturin#2125) * Only use base python executable when `MATURIN_PEP517_USE_BASE_PYTHON` is set in [#2134](PyO3/maturin#2134)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds minimal iOS support to Maturin.
Related issue: #1742
Solution is merely based on #1742 by @holzschu
It works! I've been able to build pydantic-core package for iOS and simulator using crossenv.
The only issue is wheel tag which is always
-cp312-cp312-ios_23_5_0_arm64.whlfor all three triples passed toCARGO_BUILD_TARGET:aarch64-apple-iosaarch64-apple-ios-simx86_64-apple-iosthough binaries inside
.whlhave correct architecture._PYTHON_HOST_PLATFORMis also set, but is not respected.I'd like to improve that in this PR as well (if that's possible), but don't know where to dig. Some hint/guidance would be appreciated.